Simple phpBB3 Smiley Pagination Mod V1

[Vladd44]

There didn't seem to be one around for phpbb3, and clearly the forum needed pagination for smilies again.

So Here it is. I saw a few people posting in places looking for one, hopefully they will find it.

Pagination script link

This thread will ultimately be added to the end of the thread to allow continuity of discussion.

Also included is a zipped version.

I have kept it very basic, but I am sure it will change over time.

[Stoker]

I installed this Mod and changed the smilie count to 50.
Uploaded and refreshed.

Got this error:

Code: Select all

[phpBB Debug] PHP Notice: in file /includes/functions_posting.php on line 120: mysql_query() [function.mysql-query]: Access denied for user 'www-data'@'localhost' (using password: NO)
[phpBB Debug] PHP Notice: in file /includes/functions_posting.php on line 120: mysql_query() [function.mysql-query]: A link to the server could not be established
[phpBB Debug] PHP Notice: in file /includes/functions_posting.php on line 121: mysql_num_rows(): supplied argument is not a valid MySQL result resource
[phpBB Debug] PHP Notice: in file /includes/functions_posting.php on line 130: Undefined variable: pagination

And there is no pagination.

I use 3.0.2

Can this be fixed?

[Vladd44]

Can you post your functions_posting.php ?

I will see what I can do.

I will also upgrade to 3.02 to see if the problem could be related to it somehow, I have been slacking and have still be running 3.01 .

[Stoker]

Yes, here You go:

posting.zip

functions_posting.php

(17.93 KiB) Downloaded 10 times

[Vladd44]

I updated it, it should work fine now.

Sorry about the issues, let me know if there are any additional problems. And if possible, please let me know that it worked as well.

I noticed another issues that could crop up if someone was not using the default prefix, so I corrected that as well, even though I doubt that was your problem.

What was changed was the following.....

Code: Select all

#
#-----[ FIND ]---------------------------------------------------
#
      page_footer();
#
#-----[ Before, ADD ]-------------------------------------------
#
// additions to pagination
if ($start){
$cp = $start / $smiley_limit;
} else {
$cp = 1;
}
$pagination = '';
$ref = $db->sql_query('SELECT * FROM '. SMILIES_TABLE );
$n_smiles = $db->sql_affectedrows('SELECT * FROM '. SMILIES_TABLE );
$total_pages =ceil($n_smiles/$smiley_limit);
for ($apl=1; $apl<=$total_pages; $apl++) {
$pagination.= '<a href="../posting.php?mode=smilies&start='.(($apl-1)*$smiley_limit).'"> '.$apl.' </a>';
}
$pagination = "<br><center>Now Showing Page $cp of $total_pages. <br>Total Pages $pagination </center>";
$template->assign_vars(array(
'PAGINATION' => $pagination ));
// end additon to pagination

[Stoker]

Thanks for updating.
No debug errors but i cant go to any other smilie page than page 1.

[Vladd44]

Does it show the page numbers but not as links?

Or does it not show the page numbers?

If you don't mind pm me or post a link to your forum. Whichever you prefer, so I can see what you are seeing.

Or at least a screen cap.

[Stoker]

Everything is in the right place.
It shows page numbers as links, but when I click (2 or 3) the page dont change as it should.

[Vladd44]

Please reinstall the mod.
I made several additional changes, this should correct your problem.

Once again, thanks for your input, and your patience.

[Stoker]

Thanks, now it is working perfect

[Vladd44]

Glad to be of assistance.

[Sunka]

Hi...look very nice MOD...But only subsilver instructions are given...what about Prosilver?

[Vladd44]

Code: Select all

Find
<!-- BEGIN smiley -->

Before Add

<span class="genmed">{PAGINATION}</span>

[Sky]

Great, much needed mod - thanks.

I've installed it, and it's working but for the fact that I'm only getting the first page of smileys, and no page numbers, so no way of getting to the rest of the smileys.

[Edited to add that I'm using prosilver]

[Vladd44]

Did you clear cache?

[Sky]

Yes.

[Vladd44]

Does it show a different page of smileys if you were to manually change the address
such as

http://yourdomain.com/posting.php?mode=smilies&start=50

Also, in styles/prosilver/template/posting_smilies.

Code: Select all

#
#-----[ FIND ]---------------------------------------------------
#
<!-- BEGIN smiley -->

#
#-----[ BEFORE, ADD ]---------------------------------------------
#
<span class="genmed">Pages {PAGINATION}</span>


Then clear cache, does at least the word pages show up?

If so, please recheck this section

Code: Select all

#
#-----[ FIND ]---------------------------------------------------
#
page_footer();
#
#-----[ Before, ADD ]-------------------------------------------
#
// additions to pagination
if ($start){
$cp = $start / $smiley_limit+1;
} else {
$cp = 1;
}
$pagination = '';
$ref = $db->sql_query('SELECT * FROM '. SMILIES_TABLE );
$n_smiles = $db->sql_affectedrows('SELECT * FROM '. SMILIES_TABLE );
$total_pages =ceil($n_smiles/$smiley_limit);
for ($apl=1; $apl<=$total_pages; $apl++) {
$pagination.= '<a href="'.$phpbb_root_path.'posting.php?mode=smilies&start='.(($apl-1)*$smiley_limit).'"> '.$apl.' ';
}
$pagination = "
Now Showing Page $cp of $total_pages.
Total Pages $pagination
";
$template->assign_vars(array(
'PAGINATION' => $pagination ));
// end additon to pagination

[Sky]

Does it show a different page of smileys if you were to manually change the address
such as

http://yourdomain.com/posting.php?mode=smilies&start=50

Yes, this takes me to page three of smileys (I set the display limit to 25), with the link to go to pages one and two.

Also, in styles/prosilver/template/posting_smilies.

Code: Select all

#
#-----[ FIND ]---------------------------------------------------
#
<!-- BEGIN smiley -->

#
#-----[ BEFORE, ADD ]---------------------------------------------
#
<span class="genmed">Pages {PAGINATION}</span>


Then clear cache, does at least the word pages show up?

No, nothing changes. I have the word 'Smilies' at the top of the smiley display (as before), but no other words.

[Vladd44]

Clarify the bold part please.

Yes, this takes me to page three of smileys (I set the display limit to 25), with the link to go to pages one and two.

And the word pages does not show up at all?

[Sky]

This gives me a page with the words 'Pages Now Showing Page 3 of 3. Total Pages 1 2 3' (where 1 and 2 are links) followed by the smileys.

The word 'Pages' does not appear anywhere on the posting page - I even did a search in case I'd missed it, just the first page of 25 smilies with the heading 'Smilies'.

[Vladd44]

'Pages Now Showing Page 3 of 3. Total Pages 1 2 3'

It has to be a cache issue, Since both the word 'Pages' is showing up (First word) and followed by the pagination itself (Now Showing Page 3 of 3. Total Pages 1 2 3') showed on the following pages when you went to them (for the first time) manually.

Go back to admin panel and clear the cache again.

[Sky]

I have cleared the cache again (several times), with no difference.

[Vladd44]

Let me explain my dilemma.

You added the word Pages styles/prosilver/template/posting_smilies.html, but it doesn't show on the first page..but does on the others?

There is no way for this to happen, unless it is using another html template. That is the reason I had you add it.

Other than the phpbb3 internal caching system I cannot imagine ANYTHING that could cause this problem.

Care to send me a link to your forum via pm or post it in a link, either way.

[Sky]

I expect I'm explaining things badly.

It doesn't appear on the posting page, but if I go to myforums/posting.php?mode=smilies&start=50 it shows up, and if I go to /posting.php?mode=smilies&start=0, which is page one, it shows up there too - but these are just pages of smilies.

It is just the posting page where it doesn't appear, so there's no way for my members to access the second and third pages of smilies.

I'll PM you the link.

[Vladd44]

As opposed to where mine has a "view more smilies" link?

Give me a sec, and I will sort out where to add one, I noticed my default subsilver did not have such a thing either.